[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fix for bug #85
Ondrej LHOTAK wrote:
> I have applied your patch for bug 85.
Thanks!
> For bug 84, I have not applied your patch for two reasons:
>
> 1. I think the SourceFile attributes should only be kept when a
> command-line switch is given, along the lines of keep-line-number and
> keep-bytecode-offset. This is a trivial change that I can make.
Agreed.. thanks for doing that work.
> 2. Soot doesn't appear to have support for writing class attributes to
> jasmin and then to class files. I think we should add such support
> before adding support for SourceFile attributes so that these attributes
> are written out correctly as well as read in. I don't know much about
> how the jasmin output code works. Does anyone want to take a stab at
> this?
I don't have time to work on this, but hopefully someone more
Jasmin-aware does.
FYI, another useful attribute to handle would be the InnerClass
attribute.
Cheers,
-Archie
__________________________________________________________________________
Archie Cobbs * CTO, Awarix * http://www.awarix.com