[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: ConstantValueTag patch
This patch has now been committed to the Soot Subversion repository as
revision 1438.
Ondrej
On Thu, May 13, 2004 at 04:41:39PM +0100, Laurie Hendren wrote:
> Yes, we should add them. I'll ask Jennifer to do it, we also need
> them for a current project.
>
> Thanks, Laurie
>
>
> +----------------------------------------------------------------+
> | Laurie Hendren, Professor, Computer Science, McGill University |
> | Visiting Fellow, Oxford University Computing Laboratory, |
> | Wolfson Building, Parks Road Fax: +44 (0) 1865 273839 |
> | Oxford, UK OX1 3QD Tel: +44 1865 283551, 01865 283551 (UK) |
> | hendren@cs.mcgill.ca http://www.sable.mcgill.ca/~hendren |
> +----------------------------------------------------------------+
>
> On Tue, 11 May 2004, Archie Cobbs wrote:
>
> > Archie Cobbs wrote:
> > > I've got a patch that adds support for "ConstantValueTag" tags in Soot.
> > > These tags are associated with SootField's that are initialized with
> > > constant values in the class files. Right now in Soot this information
> > > is simply lost; this patch tries to address that problem.
> > >
> > > This patch is part of a larger patch that also adds "SourceFileTag"
> > > and "InnerClassTag" tags (also information currently lost with Soot),
> > > plus a couple of other minor fixes (some of which are already in CVS;
> > > this patch is against version 2.1.0).
> > >
> > > Previously this patch was deemed not suitable because it only adds
> > > support for reading these in, but does not add support to the jimple
> > > language, parser, etc. for writing them out.
> > >
> > > However, I'd like to request again that they (or some equivalent) be
> > > added, on the simple principle that 1/2 of an implementation is better
> > > than no implementation at all, and it doesn't look like a complete
> > > implementation is in the works by anyone.
> > >
> > > Moreover, I'm guessing these new tags would be useful to other folks
> > > than just me. Do other folks have objections to adding them?
> >
> > I didn't hear any objections to committing these patches. Could
> > some Soot maintainer(s) give some feedback?
> >
> > Thanks,
> > -Archie
> >
> > __________________________________________________________________________
> > Archie Cobbs * CTO, Awarix * http://www.awarix.com
> >
>