Re: CastCheckEliminator

[Archie Cobbs <archie@dellroad.org>]

Ondrej LHOTAK wrote:
> > > > Is it a well-known fact that CastCheckEliminator is broken [1]?
> > > > Just curious if so, and whether there are any plans to fix it.
> > > 
> > > It was not well-known that it's broken until I read your bug report this
> > > morning. I'm working on fixing it...
> > 
> > Thanks.. complaining about it is easy for me :-) I appreciate
> > your taking a look at fixing it.
> 
> This is now fixed in revision 1627.
> 
> The bug was not in the CastCheckEliminator itself, but rather in the
> flow analysis classes which were calling merge with in1 aliased to out.
> Modifying out therefore made unexpected modifications to in1. This is
> the bug that Saswat Anand reported a while ago in relation to the
> must-alias analysis. Therefore, this fix should also fix that analysis.

I've back-patched soot 2.1.0 with revision #1627 and that
seems to fix the problem for me.

Thanks!
-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com